Fix for a radio switch/buttons layout in subform field type#43887
Closed
artur-stepien wants to merge 2 commits intojoomla:5.1-devfrom
Closed
Fix for a radio switch/buttons layout in subform field type#43887artur-stepien wants to merge 2 commits intojoomla:5.1-devfrom
artur-stepien wants to merge 2 commits intojoomla:5.1-devfrom
Conversation
Member
|
@artur-stepien Is it the same issue as reported with issue #43800 ? If so, there is a PR already: #43804 . To me it seems to be the same issue but that PR and yours here solve it in different ways. Could you check the other PR? |
Member
|
We already have the fix #43804 |
Contributor
Author
|
@Fedik @richard67 #43804 Will fix it too so no need to waste time on testing. Was searching for the ticket before creating PR but could not find it. |
Member
|
@artur-stepien Thanks for checking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change made last month in a

subformfield broke subform support when there is ajoomla.form.field.radio.switcher(and most likelyjoomla.form.field.radio.buttons) layout set on the field. The result is Uncaught TypeError like thisIn short, the script is looking for a
radioclass in element parents. Where the script itself works fine, theswitcherandbuttonslayout for the radio field lacks theradioclass on a fieldset.Summary of Changes
Added
radioclass tojoomla.form.field.radio.switcherandjoomla.form.field.radio.buttonslayouts.Testing Instructions
Add this field XML to any of the core modules like (eg
mod_banners) and try to add new row in this field:Actual result BEFORE applying this Pull Request
Uncaught TypeError: can't access property "nodeName", b is nullExpected result AFTER applying this Pull Request
New row in a subform is added
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed